Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant is marked protected starting with composer 2.3 #79

Closed
dkreuer opened this issue Mar 31, 2022 · 0 comments · Fixed by #86
Closed

Constant is marked protected starting with composer 2.3 #79

dkreuer opened this issue Mar 31, 2022 · 0 comments · Fixed by #86
Milestone
2.0.1

Comments

@dkreuer
Copy link
Contributor

dkreuer commented Mar 31, 2022

TYPE constant is marked protected therefore not accessible starting from composer 2.3 breaking the plugin functionality.

composer-plugin-license-check/src/LicenseCheckPlugin.php

Line 104 in 405dd13

case InstallOperation::TYPE:

Possible solution:

  • Switch to instanceof check in patch version

Related issue in upstream: composer/composer#10550
@dkreuer dkreuer changed the title Content is marked protected starting with composer 2.3 Constant is marked protected starting with composer 2.3 Mar 31, 2022
@dkreuer dkreuer added this to the 2.0.1 milestone Mar 31, 2022
@dkreuer dkreuer mentioned this issue Apr 4, 2022
Merged
@dkreuer dkreuer modified the milestones: 2.0.1, 2.1.0 Apr 4, 2022
@dkreuer dkreuer linked a pull request Apr 4, 2022 that will close this issue
Fix #79 composer 2.3 incompatibility #86
Merged
dkreuer added a commit that referenced this issue Apr 4, 2022
@dkreuer
Merge pull request #86 from MetaSyntactical/fix-79-composer-2.3-incom…
97f06c1 
…patibility

Fix #79 composer 2.3 incompatibility
@dkreuer dkreuer closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging a pull request may close this issue.

Fix #79 composer 2.3 incompatibility MetaSyntactical/composer-plugin-license-check
1 participant
@dkreuer