implicit "--no-check-lock" (10715, --no-check-lock; 1/3)

- `{"config": {"lock": false}}` is an implicit `--no-check-lock` issue: 10715
composer · Apr 12, 2022 · dc84f03 · dc84f03
1 parent 9bfd059
commit dc84f03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/phpstan/baseline.neon b/phpstan/baseline.neon
@@ -2375,6 +2375,11 @@ parameters:
 			count: 2
 			path: ../src/Composer/Command/ValidateCommand.php
 
+		-
+			message: "#^Only booleans are allowed in &&, mixed given on the right side\\.$#"
+			count: 1
+			path: ../src/Composer/Command/ValidateCommand.php
+
 		-
 			message: "#^Only booleans are allowed in a negated boolean, array\\<Composer\\\\Package\\\\BasePackage\\> given\\.$#"
 			count: 1

diff --git a/src/Composer/Command/ValidateCommand.php b/src/Composer/Command/ValidateCommand.php
@@ -95,6 +95,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $lockErrors = array();
         $composer = Factory::create($io, $file, $input->hasParameterOption('--no-plugins'));
+        $checkLock = $checkLock && $composer->getConfig()->get('lock'); // config.lock = false ~= implicit --no-check-lock
         $locker = $composer->getLocker();
         if ($locker->isLocked() && !$locker->isFresh()) {
             $lockErrors[] = '- The lock file is not up to date with the latest changes in composer.json, it is recommended that you run `composer update` or `composer update <package name>`.';