Fix 7zip issues on windows when mixing forward and backslashes, fixes #…

…10058
composer · Aug 18, 2021 · 5c20168 · 5c20168
1 parent b7bb771
commit 5c20168
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Composer/Downloader/ZipDownloader.php b/src/Composer/Downloader/ZipDownloader.php
@@ -115,6 +115,12 @@ private function extractWithSystemUnzip(PackageInterface $package, $file, $path)
 
         $commandSpec = reset(self::$unzipCommands);
         $command = sprintf($commandSpec[1], ProcessExecutor::escape($file), ProcessExecutor::escape($path));
+        // normalize separators to backslashes to avoid problems with 7-zip on windows
+        // see https://github.com/composer/composer/issues/10058
+        if (Platform::isWindows()) {
+            $command = sprintf($commandSpec[1], ProcessExecutor::escape(strtr($file, '/', '\\')), ProcessExecutor::escape(strtr($path, '/', '\\')));
+        }
+
         $executable = $commandSpec[0];
 
         $self = $this;