Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pass composer json filename to output formatter #624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bobvandevijver
Copy link

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Fixes #623. Only the filename of the parsed composer.json is now given to the output parsers. As this file should always be on the root of the project, this should also be correct for the output formatters.

@bobvandevijver
Copy link
Author

bobvandevijver commented Mar 11, 2024

@icanhazstring Anything I can do to help get this merged and tagged?

@icanhazstring
Copy link
Member

Could you come up with a test to verify that?maybe using vfsstream

@bobvandevijver
Copy link
Author

I do not know what to test here to be honest, the only real change I added is that the path passed to the formatter no longer is an absolute path, but the filename relative to the project by using a native PHP function.

@bobvandevijver
Copy link
Author

@icanhazstring Anything that can be done to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab formatter: unusable file path for composer.json
2 participants