Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to humbug/box 4 and remove support builds for php < 8.1 #600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

icanhazstring
Copy link
Member

Replace #592

@icanhazstring icanhazstring mentioned this pull request Nov 30, 2023
7 tasks
@theofidry
Copy link

theofidry commented Dec 12, 2023

Hmm I'm looking at the produced PHAR there is definitely something very weird, need to check some more. It's the sort of error that if it was produced on the repo, the entire CI would fail. So really wondering what caused this

@theofidry
Copy link

Nevermind it was me being on the right branch but the wrong commit. Can you retry with 4.6? It should just work (also you can remove the --no-parallel)

@icanhazstring
Copy link
Member Author

Will check, thx

@theofidry
Copy link

Hm weird that you get the same error, can you reproduce it locally? (I couldn't)

@icanhazstring
Copy link
Member Author

I think there is another problem.
As I "quickly" removed PHP 8.1.

Will have to check 😅

@theofidry
Copy link

btw I see you have some annoyances with the required builds, if I may I highly suggest to opt for something like here. It offers much more flexibility and avoid to have to update the protection rules whenever you upgrade the matrix

@icanhazstring icanhazstring force-pushed the build/box-4 branch 2 times, most recently from 4e67c59 to 96fddde Compare January 2, 2024 06:33
@icanhazstring icanhazstring force-pushed the build/box-4 branch 4 times, most recently from 76842e3 to 4118c52 Compare January 2, 2024 06:43
@icanhazstring
Copy link
Member Author

icanhazstring commented Jan 2, 2024

@theofidry still same problem, but only in the action itself.
Locally it runs fine.

DateError was just defined with php 8.3 so the error does not make sense.
Seems like the PHP_VERSION_ID constant has a weird value when the action runs.

@icanhazstring icanhazstring force-pushed the build/box-4 branch 5 times, most recently from 8133a64 to 53874a1 Compare January 2, 2024 07:09
@icanhazstring
Copy link
Member Author

Nevermind, found some more information about what could go wrong.
I think it has something todo with the

humbug_phpscoper_expose_class('DateError', '__ComposerUnused__\DateError');

inside the phar vendor/autoload.php.
Will dig a little deeper.

@icanhazstring
Copy link
Member Author

Here are the autoload.php from local and action
autoload-action.txt
autoload-local.txt

The only difference I find is that the DateError expose has a different order.
Don't know if that might be a problem.

@icanhazstring icanhazstring force-pushed the build/box-4 branch 2 times, most recently from 4e71558 to 452ac5d Compare January 2, 2024 07:56
@theofidry
Copy link

Got a laptop back so will try to check it out ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants