Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pattern exclusion support for "-implementation" packages #223

Merged

Conversation

verenaroe
Copy link
Contributor

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Additional information

This PR adds support for regex pattern exclusions. By default it excludes "-implementation" and therefore fixes issue #93.

Notes

Should I add all virtual packages to named exclusions? Can they easily be found?

@icanhazstring
Copy link
Member

Nice, this is what I was aiming for. A simple solution to remove -implementation packages.
Very well done, thank you 💪

LGTM 🚀

@icanhazstring icanhazstring merged commit d52df84 into composer-unused:main Oct 21, 2021
@icanhazstring
Copy link
Member

icanhazstring commented Oct 21, 2021

Just a quick side question. Do you have Twitter handle? Would like so write a nice post 🙂

You can also just follow me @icanhazstring so that you don't need to share it here 😉

@verenaroe
Copy link
Contributor Author

I don't use social media at all 😬 Maybe you can use my github name or website? Please send the post to me, I would love to read it 😃 Saw your random-issue-picker in the PHP Annotated Monthly from Jetbrains 😀

@verenaroe verenaroe deleted the feature/pattern-matching branch October 21, 2021 08:56
@icanhazstring
Copy link
Member

Can you send me an email to ando@icanhazstring.net so that I can send you the tweet before posting it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants