Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the excludePackage option #222

Merged
merged 2 commits into from Oct 19, 2021

Conversation

verenaroe
Copy link
Contributor

@verenaroe verenaroe commented Oct 18, 2021

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Pull Request Description

This PR fixes #217 and #93 and partially implements the excludePackage option. Let me know if I have to change something.

@icanhazstring
Copy link
Member

Thanks for the PR 💪

After a quick glance over it, it looks good so far. Will have a deeper look at it asap.

Copy link
Member

@icanhazstring icanhazstring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change needed, other than that, this PR is amazing. Thank you very much 🙏

Copy link
Member

@icanhazstring icanhazstring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@icanhazstring icanhazstring merged commit 7dbc4c3 into composer-unused:main Oct 19, 2021
@verenaroe
Copy link
Contributor Author

Thank you! 😀

@icanhazstring
Copy link
Member

If you want, you can go for #93 as well :)
As you've implemented the groundwork for it already.

@verenaroe
Copy link
Contributor Author

Yes I would love to! 😃

@verenaroe verenaroe deleted the feature/excludepackages branch October 19, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore composer-plugin-api (and exclude packages) from reported packages
2 participants