New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Implement InstanceofStrategy #100
Merged
icanhazstring
merged 1 commit into
composer-unused:main
from
localheinz:feature/instanceof
Oct 28, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Icanhazstring\Composer\Unused\Parser\PHP\Strategy; | ||
|
||
use PhpParser\Node; | ||
|
||
final class InstanceofStrategy implements ParseStrategyInterface | ||
{ | ||
public function meetsCriteria(Node $node): bool | ||
{ | ||
if (!$node instanceof Node\Expr\Instanceof_) { | ||
return false; | ||
} | ||
|
||
if (!$node->class instanceof Node\Name) { | ||
return false; | ||
} | ||
|
||
return $node->class->isFullyQualified() || $node->class->isQualified(); | ||
} | ||
|
||
/** | ||
* @param Node&Node\Expr\Instanceof_ $node | ||
* @return array<string> | ||
*/ | ||
public function extractNamespaces(Node $node): array | ||
{ | ||
/** @var Node\Name $class */ | ||
$class = $node->class; | ||
|
||
return [ | ||
$class->toString(), | ||
]; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
namespace Foo\Bar { | ||
class Baz {} | ||
class Qux {} | ||
class Quz {} | ||
class Corge {} | ||
} | ||
|
||
namespace { | ||
|
||
// // https://github.com/composer-unused/composer-unused/pull/100#discussion_r506167242 | ||
// | ||
// use Foo\Bar; | ||
// | ||
// if ($foo instanceof Bar\Baz) { | ||
// // usage should be detected because class is a name, relative to imported namespace | ||
// } | ||
|
||
if ($foo instanceof Foo\Bar\Qux) { | ||
// usage should be detected because class is a fully-qualified name used in the root namespace | ||
} | ||
|
||
if ($foo instanceof \Foo\Bar\Quz) { | ||
// usage should be detected because class is a fully-qualified name relative to the root namespace | ||
} | ||
|
||
$name = 'Foo\Bar\Corge'; | ||
|
||
if ($foo instanceof $name) { | ||
// usage should not be detected because class is a variable expression | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this method return an array of class names or an array of namespace names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the FQN of the class.
The method name is changed in #89 to
extractSymbolNames
which is more fitting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on this question I am trying to improve phpdocs to make these point clear:
#111