Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab formatter: unusable file path for composer.json #623

Open
bobvandevijver opened this issue Feb 19, 2024 · 1 comment · May be fixed by #624
Open

Gitlab formatter: unusable file path for composer.json #623

bobvandevijver opened this issue Feb 19, 2024 · 1 comment · May be fixed by #624

Comments

@bobvandevijver
Copy link

When using the Gitlab formatter, the full path to the composer.json file is used, which is reported to the interface.

image

When clicking the link, you will get a notification that the file does not exist in the repository:

image

This might also be an issue with the Github formatter, which is the only other formatter to use the $composerJsonPath param.

I believe this path should be relative to the execution dir. What do you think?

@bobvandevijver
Copy link
Author

It looks like this actually also causes the reported finding to be incorrect, as that seems to compare the full item including the full path.

@bobvandevijver bobvandevijver linked a pull request Feb 20, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant