refs issue:11706 Resolving the Alias value of Alias type node #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arankeparth
force-pushed
the
fix_ignore_overwrite
branch
from
e374cdd
to
e40521f
Compare
Signed-off-by: parth aranke <arankeparth1912@gmail.com>
arankeparth
force-pushed
the
fix_ignore_overwrite
branch
from
e40521f
to
de965e5
Compare
|
Please review somebody |
|
@ndeloof please review. |
ndeloof
reviewed
Apr 11, 2024
Signed-off-by: parth aranke <arankeparth1912@gmail.com>
arankeparth
force-pushed
the
fix_ignore_overwrite
branch
from
f94bcd7
to
1e1af29
Compare
|
@ndeloof Addressed review comments and added test. |
ndeloof
approved these changes
Apr 11, 2024
|
@ndeloof how to get this merged? |
|
@arankeparth let's wait for a second review, then I think we can merge |
|
@glours please review. |
|
@milas can you please review this? |
|
@jhrotko @laurazard somone please review. |
|
@arankeparth please don't push pressure on the team, will be reviewed once we get bandwidth to review |
Sorry for that. |
glours
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Aliaskind, we need to preserve the current path and process the Alias value separately.!overwritetag won't be ignored.Testing:
extendswith YAML merge anchors will ignore !override and !reset docker/compose#11706containers are spawned successfully:
Here, we can see in the configs section for
ythat there is only one entry forconfigs