normalization creates implicit default network only when used by some service
#595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
normalizeNetworks
branch
2 times, most recently
from
f1f201f
to
3f804fc
Compare
…me service Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
force-pushed
the
normalizeNetworks
branch
from
3f804fc
to
8ff6e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultimplicit network should not be introduced by normalization if not explicitly used by a service.This let
normalizeNetworksdetect `default" network is used by some services and create this implicit network only if required