let resourceloader compute relative working dir #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
relative_workingdir
branch
from
dc6d618
to
4d0ac77
Compare
ndeloof
force-pushed
the
relative_workingdir
branch
2 times, most recently
from
0811e85
to
7aaf043
Compare
jhrotko
reviewed
Feb 29, 2024
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
relative_workingdir
branch
from
7aaf043
to
6e303f4
Compare
jhrotko
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nesting includes + extends recursively,
WorkingDiris set to a relative path, sofilepathfunc fail to compute absolute/relative paths, this is whyResourceLoader.Dirwas introduced. But I forgot to use it to compute include's relative workingdir. This PR fixes this mistakecloses docker/compose#11552