[EN-158] allow override compose.yaml to REMOVE elements #380
+473
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
override_reset
branch
3 times, most recently
from
c0cb60f
to
544e37d
Compare
milas
approved these changes
Mar 30, 2023
loader/null.go
Outdated
| return p._applyNullOverrides(reflect.ValueOf(target), tree.NewPath()) | ||
| } | ||
|
|
||
| func (p *ResetProcessor) _applyNullOverrides(val reflect.Value, path tree.Path) error { |
There was a problem hiding this comment.
Nit - can just be applyNullOverrides 😛
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
changed the title
glours
approved these changes
Apr 6, 2023
|
Once compose-spec/compose-spec#330 is approve I'll propose changes there to introduce support for this mechanism |
zackgalbreath
added a commit
to Kitware/CDash
that referenced
this pull request
Jun 9, 2023
For now, this seems to be the best we can do. Once docker compose v2.19 is released we should be able to update the worker service by "extending" the cdash service, removing the need for manually editing the production config YAML. In particular, we need the new "!reset" feature to prevent both the web service and the worker from attempting to bind port 443. compose-spec/compose-go#380
zackgalbreath
added a commit
to Kitware/CDash
that referenced
this pull request
Jun 9, 2023
For now, this seems to be the best we can do. Once docker compose v2.19 is released we should be able to update the worker service by "extending" the cdash service, removing the need for manually editing the production config YAML. In particular, we need the new "!reset" feature to prevent both the web service and the worker from attempting to bind port 443. compose-spec/compose-go#380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an alternative to #379
using a custom yaml tag
!reset(final name to be debated), this let user define compose.override.yaml to REMOVE elements from original model.Also supports removal from maps, like
environment, but miss support for removal from list (but feasible)