Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate service.platform is declared by build.platforms #368

Merged
merged 1 commit into from Mar 20, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Mar 15, 2023

This enforces consistency doing "build" as part of "up"

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard
Copy link
Member

laurazard commented Mar 15, 2023

Also, we should probably update https://github.com/compose-spec/compose-spec/blob/master/05-services.md#platform to mention that if build.platforms is set then service.platform needs to be one of those values.

@ndeloof ndeloof merged commit 0d0962d into compose-spec:master Mar 20, 2023
@ndeloof ndeloof deleted the check_platforms branch March 20, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants