Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix network aliasses merge logic to conform to docker compose v1 #323

Merged
merged 1 commit into from Dec 19, 2022
Merged

fix network aliasses merge logic to conform to docker compose v1 #323

merged 1 commit into from Dec 19, 2022

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Nov 30, 2022

@ndeloof
fix network aliasses merge logic to conform to docker compose v1
615df13 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof marked this pull request as ready for review December 15, 2022 13:40
glours
glours approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof merged commit ecbc28d into compose-spec:master Dec 19, 2022
@ndeloof ndeloof deleted the merge_aliasses branch December 19, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glours glours glours approved these changes

@laurazard laurazard Awaiting requested review from laurazard

@milas milas Awaiting requested review from milas

@nicksieger nicksieger Awaiting requested review from nicksieger

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Network aliases from multiple docker-compose files do not get merged
2 participants
@ndeloof @glours