Fix absolute paths in secrets and inherited volumes #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secret files are converted to bind mounts, so handle them in the same way as volumes - detect and handle unix-like absolute paths. Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
Volumes keep unix-like absolute paths untouched, which was not the case for inherited volumes from extended services. Fix this by using the same method, which is used by standard volume path resolution. Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
|
Tested also in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volumes detect and handle unix-like absolute paths also on Windows. Secrets are translated to bind mounts, so handle them the same way. While at it, fix also inherited absolute path volumes from extended services.
Fixes #304