Add missing LinkLocalIPs to ServiceNetworkConfig #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremiah Millay <jmillay@fastly.com>
floatingstatic
commented
Jul 22, 2022
Signed-off-by: Jeremiah Millay <jmillay@fastly.com>
floatingstatic
force-pushed
the
link_local_ips
branch
from
e2ce61b
to
ec8d637
Compare
glours
approved these changes
Jul 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeremiah Millay jmillay@fastly.com
This addresses #288 and I believe is a prerequisite to fixing docker/compose#9659 (happy to take care of that as well once this change is approved/merged).