Fix lookup precedence

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
compose-spec · Jul 4, 2022 · 1347fed · 1347fed
1 parent a313a1e
commit 1347fed
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/dotenv/parser.go b/dotenv/parser.go
@@ -37,7 +37,6 @@ func parseBytes(src []byte, out map[string]string, lookupFn LookupFn) error {
 		}
 
 		if inherited {
-
 			value, ok := lookupFn(key)
 			if ok {
 				out[key] = value
@@ -50,9 +49,6 @@ func parseBytes(src []byte, out map[string]string, lookupFn LookupFn) error {
 		if err != nil {
 			return err
 		}
-		if lookUpValue, ok := lookupFn(key); ok {
-			value = lookUpValue
-		}
 
 		out[key] = value
 		cutset = left

diff --git a/loader/loader.go b/loader/loader.go
@@ -623,6 +623,9 @@ func resolveEnvironment(serviceConfig *types.ServiceConfig, workingDir string, l
 	environment := types.MappingWithEquals{}
 
 	if len(serviceConfig.EnvFile) > 0 {
+		if serviceConfig.Environment == nil {
+			serviceConfig.Environment = types.MappingWithEquals{}
+		}
 		for _, envFile := range serviceConfig.EnvFile {
 			filePath := absPath(workingDir, envFile)
 			file, err := os.Open(filePath)