fix(app): Fix enum member types parsing #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vogloblinsky here is the another case |
|
Could you add a integration test please ? |
|
Oki, I will, a little bit later |
|
Thanks |
|
I am back, I gonna write the test @vogloblinsky |
pawtwa
force-pushed
the
fix-enum-member-types-parsing
branch
from
d7bbbf5
to
8ff0582
Compare
|
@vogloblinsky I have just pushed the changes |
pawtwa
force-pushed
the
fix-enum-member-types-parsing
branch
2 times, most recently
from
1ab86ef
to
ac9d740
Compare
Fix matching the default value and radio options for any @input() of enum type
pawtwa
force-pushed
the
fix-enum-member-types-parsing
branch
from
ac9d740
to
7509681
Compare
|
Thanks for the test and the PR |
|
@vogloblinsky thanks for accepting the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix matching the default value and radio options for any @input() of enum type