changed knowledgeBase.js, removed react-easy-emoji redundancy #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like react-easy-emoji updated their default CDN so I will try to simply update that package and see if it works https://github.com/appfigures/react-easy-emoji/blob/master/CHANGELOG.md |
This was referenced Nov 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue resulted from using react-easy-emoji.
react-easy-emoji uses twemoji and more relevantly the MaxCDN ( which originally hosted the twemoji images). MaxCDN no longer host those images hence the error.
Since the code already is passing emojis as hardcoded text, the end user is downloading the emojis and so the react-easy-emoji isnt necessary. I just removed it from the knowledgeBase component and left the passed in emoji as plaintext which should work across all browsers.