Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions of the new_inh_model section #115

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Revisions of the new_inh_model section #115

wants to merge 39 commits into from

Conversation

alberto-antonietti
Copy link
Collaborator

What does this PR do?

Revise the section new_inh_model

Why are we doing this?

Testing performed

Known bugs/limitations

@alberto-antonietti alberto-antonietti changed the title Some revisions of the new_inh_model section [WIP] Some revisions of the new_inh_model section May 7, 2024
@alberto-antonietti alberto-antonietti self-assigned this May 7, 2024
@alberto-antonietti
Copy link
Collaborator Author

@francescodesantis we can work on this branch for revisions of the text.

@alberto-antonietti alberto-antonietti marked this pull request as draft May 7, 2024 15:13
@thesamovar
Copy link
Contributor

Mention me in a comment when you're ready to merge!

francescodesantis and others added 11 commits May 15, 2024 17:18
@francescodesantis
Create new_inh_model\ (folder) (#121)
945e18e
@francescodesantis
Create text.md (#122)
8f34188
@francescodesantis
Delete paper/sections/new_inh_model\ (#123)
22f074f
@francescodesantis
Update paper.bib (#124)
503d63b
@francescodesantis
Update text.md (#125)
38b5895
@francescodesantis
Patch 23 (#126)
f87ba5a 
* Update text.md

* Add files via upload

* Update paper.bib

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Add files via upload

* Update text.md

* Add files via upload

* Delete paper/sections/new_inh_model/blocked_inh.jpg

* Delete paper/sections/new_inh_model/lso_mso.jpg

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md

* Update text.md
@alberto-antonietti
Merge branch 'main' into alberto-antonietti-revisions
968576f
@alberto-antonietti
Some corrections to the text
3f706ce
@alberto-antonietti @saraevers @pitmonticone
Merge main (#127)
257903a 
* Update contributor_table.md (#120)

* Fix typo in Delays.md (#119)

---------

Co-authored-by: saraevers <68342301+saraevers@users.noreply.github.com>
Co-authored-by: Pietro Monticone <38562595+pitmonticone@users.noreply.github.com>
@alberto-antonietti
Finished revision of the section inhibition model
70ee6bf
@alberto-antonietti
Merge branch 'main' into alberto-antonietti-revisions
5a8aa66
@alberto-antonietti
Copy link
Collaborator Author

@francescodesantis there are some references to be added, I indicated them as TODO_REF.

francescodesantis and others added 2 commits May 24, 2024 18:13
@francescodesantis
added references (#128)
50abb49 
* added references

* Update inhibition_model.md

* Update paper.bib

* Update paper.bib

* Update inhibition_model.md
@alberto-antonietti
Fixing last reference
6705495
@alberto-antonietti alberto-antonietti changed the title [WIP] Some revisions of the new_inh_model section Revisions of the new_inh_model section May 24, 2024
@alberto-antonietti alberto-antonietti marked this pull request as ready for review May 24, 2024 16:48
@alberto-antonietti
Copy link
Collaborator Author

@thesamovar we have finished with this. Thanks!

@thesamovar
Copy link
Contributor

thesamovar commented May 24, 2024 via email

@thesamovar
Copy link
Contributor

OK first impression:

  • There's a link in the contributor table that includes the words TODO so presumably not finished?
  • There's HTML code and hand numbered citations in the text. Please replace with MyST figure environments and MyST references. See the other markdown files (e.g. https://github.com/comob-project/snn-sound-localization/blob/main/paper/sections/basicmodel/basicmodel.md)
  • The main text you've added starts with a section titled TL;DR which probably isn't appropriate ;-) and ends with the word CONTUA on its own. I'm guessing not finished?
  • Confirm that the paragraph structure is correct? In Markdown you need a blank link between paragraphs.
  • Please add your code to the repository (it should all be available in one place).

Thanks!

francescodesantis and others added 20 commits May 28, 2024 17:19
@francescodesantis
Add files via upload
f31983d
@francescodesantis
Update contributor_table.md
c99ce9e
@francescodesantis
Update inhibition_model.md
f511acd
@francescodesantis
Update inhibition_model.md
637ad37
@francescodesantis
Update inhibition_model.md
0ba869b
@francescodesantis
Update inhibition_model.md
384c7d7
@francescodesantis
Patch 2 (#130)
c747cad 
* Update inhibition_model.md

* Add files via upload

* Update contributor_table.md

* Update inhibition_model.md

* Update inhibition_model.md

* Update inhibition_model.md

* Update inhibition_model.md
@francescodesantis
Update inhibition_model.md
6f2e35c
@francescodesantis
Delete research/5-new_inh_model.ipynb
0c868a1
@francescodesantis
Add files via upload
9d7e8d4
@alberto-antonietti
added ORCID
9ab5778
@alberto-antonietti
Merge branch 'patch-2' of https://github.com/francescodesantis/snn-so…
cd45fb8 
…und-localization into francescodesantis-patch-2
@alberto-antonietti
merging
a1af634
@alberto-antonietti
Merge branch 'francescodesantis-patch-2' into alberto-antonietti-revi…
bf97612 
…sions
@alberto-antonietti
move documentation of functions in MD cell
64b1ace
@alberto-antonietti
Merge branch 'main' into alberto-antonietti-revisions
a22920a
@francescodesantis
Update notebook (#133)
bb77dc3 
* Update notebook new_inh_model

* Delete research/model.ipynb

* Add files via upload
@alberto-antonietti
removed empty cell at the end of the notebook
67c15e2
@alberto-antonietti
Small improvements to the new_inh notebook
2069712 
Tested with newer version of NEST and python and added documentation on how to install NEST.
@alberto-antonietti
fixed broken links
8a7a75a
@francescodesantis
Copy link
Contributor

Hi @thesamovar, we've made the last changes to our section, including testing the notebook with the latest version of Nest, and it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alberto-antonietti alberto-antonietti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alberto-antonietti @thesamovar @francescodesantis