Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum version to Java 11 (and test on 21 as well) #299

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Oct 2, 2023

Bump actions/setup-java to v2 as well, which requires specifying a distribution and use 8 instead of 1.8.

@robinst
Copy link
Collaborator Author

robinst commented Oct 2, 2023

Ok, will have to raise the minimum Java version first, see error on 21:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project commonmark-test-util: Compilation failure: Compilation failure: 
Error:  Source option 7 is no longer supported. Use 8 or later.
Error:  Target option 7 is no longer supported. Use 8 or later.

Bump `actions/setup-java` to `v2` as well, which requires specifying a
distribution and use 8 instead of 1.8.
@robinst robinst changed the title Test on Java 21 Raise minimum version to Java 11 (and test on 21 as well) Feb 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a88ab23) 94.30% compared to head (01fd773) 94.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #299   +/-   ##
=========================================
  Coverage     94.30%   94.30%           
  Complexity      227      227           
=========================================
  Files           124      124           
  Lines          3633     3634    +1     
  Branches        549      549           
=========================================
+ Hits           3426     3427    +1     
  Misses          104      104           
  Partials        103      103           

see 1 file with indirect coverage changes

@robinst
Copy link
Collaborator Author

robinst commented Feb 10, 2024

Let's go to Java 11, see #125 (comment)

Reasons:

  • Java 8 was released almost 10 years ago
  • We need 9+ to build with modules (unless we use a compatibility plugin like ModiTect; but I don't want that as it complicates the build and moves module-info to poms instead of normal files with IDE support, etc)
  • We could go to 9 but it doesn't seem like many people use 9 and not 11. 11 is also a LTS version so is better supported.

@robinst robinst merged commit cf7acdf into main Feb 10, 2024
10 checks passed
@robinst robinst deleted the java-21 branch February 10, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants