Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular JAR: Add module-info module descriptor and require Java 9+ #286

Merged
merged 9 commits into from
Mar 9, 2024

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Mar 1, 2023

We've waited long enough for the ecosystem and tools such as Android to catch up. Making it proper modular means people can run jlink on it. Fixes #125.

@ice1000
Copy link

ice1000 commented Mar 1, 2023

Nice!! Oh yeah!!

@ice1000
Copy link

ice1000 commented Mar 1, 2023

Thank you very much!!! You're the real hero!

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

Attention: Patch coverage is 96.96970% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.78%. Comparing base (870be81) to head (af61f14).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #286      +/-   ##
============================================
- Coverage     94.81%   94.78%   -0.04%     
  Complexity      252      252              
============================================
  Files           130      131       +1     
  Lines          4124     4119       -5     
  Branches        606      604       -2     
============================================
- Hits           3910     3904       -6     
- Misses          106      107       +1     
  Partials        108      108              
Files Coverage Δ
...mark/ext/gfm/tables/internal/TableBlockParser.java 98.69% <100.00%> (ø)
...gfm/tables/internal/TableMarkdownNodeRenderer.java 97.82% <100.00%> (ø)
...nt/matter/internal/YamlFrontMatterBlockParser.java 94.91% <100.00%> (ø)
...java/org/commonmark/internal/BlockQuoteParser.java 100.00% <100.00%> (ø)
...src/main/java/org/commonmark/internal/Bracket.java 100.00% <ø> (ø)
...org/commonmark/internal/FencedCodeBlockParser.java 98.33% <100.00%> (ø)
...in/java/org/commonmark/internal/HeadingParser.java 98.63% <100.00%> (ø)
.../java/org/commonmark/internal/HtmlBlockParser.java 100.00% <100.00%> (ø)
...g/commonmark/internal/IndentedCodeBlockParser.java 92.59% <100.00%> (ø)
...java/org/commonmark/internal/InlineParserImpl.java 97.34% <100.00%> (ø)
... and 17 more

@boyshell

This comment was marked as spam.

We've waited long enough for the ecosystem and tools such as Android to
catch up. Making it proper modular means people can run jlink on it.
Fixes #125.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noties could you have a look at these and other changes in the Android directory? The build is green with these changes, but I'm not sure I did everything properly.

There was one problem of using String#repeat (introduced in Java 11), which is not yet available on the minimum API level, which the Android build detected. I changed the code not to use that for now, and now the build is green.

@robinst robinst merged commit 4db8bba into main Mar 9, 2024
12 checks passed
@robinst robinst deleted the modular-jar branch March 9, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jlink-compatible Java9/Jigsaw module-info (not automatic modules)
4 participants