Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): add pnpm support #915

Merged
merged 1 commit into from
Jan 19, 2023
Merged

feat(init): add pnpm support #915

merged 1 commit into from
Jan 19, 2023

Conversation

chenaski
Copy link
Contributor

@chenaski chenaski commented Mar 25, 2022

Added --pnpm option. For pnpm available --save, --save-dev and --save-exact options.

Resolves: #893, resolves #858, resolves #884.

pnpm reuses options available for npm, except `force`

re: #893, re #858
@huzedong2015
Copy link

How much longer will it take?

@chenaski
Copy link
Contributor Author

Are there any extra steps I should take?

@hellorayza
Copy link

Can anyone help?

@lisen6
Copy link

lisen6 commented Jun 9, 2022

Why doesn't mine work

@pulanski
Copy link

would love to see these changes added

1 similar comment
@jiamianmao
Copy link

would love to see these changes added

@mattyaodoit
Copy link

Keen to get this merged and support pnpm

@enrique-ramirez
Copy link

Any news on this?

@chenaski
Copy link
Contributor Author

chenaski commented Sep 5, 2022

Does anyone know how everything works in this repo?

@HubooDeclan
Copy link

Can we get this merged?

@AmmarArnt
Copy link

Would love this PR merged too. Is this repo maintained?

@Ruobei
Copy link

Ruobei commented Nov 29, 2022

would love to see these changes added

@wangrongding
Copy link

Looking forward to this pr being merged. 👀

@jimthedev jimthedev merged commit c1f4142 into commitizen:master Jan 19, 2023
@github-actions
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimthedev
Copy link
Member

It released but the tests are failing. So

  1. Build should not allow this.
  2. We may need to roll back or at least mark this as breaking and fix the tests.

@chenaski
Copy link
Contributor Author

I don't think there are any breaking changes, it seems I just forgot to update azure pipeline.
We need to add a pnpm installation before running the tests.

@Jalever
Copy link

Jalever commented Aug 16, 2023

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet