Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup): output size snapshot of esm build #576

Closed
wants to merge 1 commit into from

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Mar 2, 2019

To provide useful information about the bundle size, treeshaking, etc.

@emmenko
Copy link
Member Author

emmenko commented Mar 2, 2019

This should help us improving treeshaking support, by looking at those numbers (current values below). I still don't know exactly what they mean by that what we should be looking at.

"treeshaked": {
  "rollup": {
    "code": 321329,
    "import_statements": 1038
  },
  "webpack": {
    "code": 343714
  }
}

@emmenko
Copy link
Member Author

emmenko commented Mar 2, 2019

Also, interesting point here: remix-run/react-router#6464 (comment)

Basically, avoid using classes and use hooks instead 😅

@emmenko
Copy link
Member Author

emmenko commented Mar 23, 2019

Closing this for now, as it currently fails because of this problem: TrySound/rollup-plugin-size-snapshot#24

@emmenko emmenko closed this Mar 23, 2019
@emmenko emmenko deleted the nm-rollup-size-snapshot branch March 23, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant