Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: to replace fs.access with fs.exist #1890

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rombelirk
Copy link
Contributor

@Rombelirk Rombelirk self-assigned this Apr 30, 2024
Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: f6c38b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (f8e1857) to head (f6c38b6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1890   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         147      147           
  Lines        5057     5057           
  Branches     1375     1375           
=======================================
  Hits         4792     4792           
  Misses        262      262           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -6,6 +6,15 @@ import yargs from 'yargs'

import CsvParserDiscountCode from './main'

const doesFileExist = (filePath) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little observation, it will be nice if we can add a simple unit test to test this function.

@ajimae
Copy link
Contributor

ajimae commented May 30, 2024

Also, to make the testing easier, I will suggest you move doesFileExist as an exported function into a util or helper file and import them everywhere else where it is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants