Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exports in discount-code-importer module #1879

Closed
wants to merge 4 commits into from

Conversation

ajimae
Copy link
Contributor

@ajimae ajimae commented Aug 4, 2023

Summary

Fix issues with modules not exporting directly as default exports in @commercetools/discount-code-importer package.

Completed tasks

  • use preconstruct and rollup bundler to bundle module
  • remove the direct babel module bunder

- use preconstruct and rollup bundler to bundle module
- remove the direct babel module bunder
@ajimae ajimae requested a review from agonbina August 4, 2023 09:24
@ajimae ajimae self-assigned this Aug 4, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: 22b4491

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1879 (804c7ca) into master (2175f68) will not change coverage.
The diff coverage is n/a.

❗ Current head 804c7ca differs from pull request most recent head 70b1d22. Consider uploading reports for the commit 70b1d22 to get more accurate results

@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files         147      147           
  Lines        5031     5031           
  Branches     1371     1371           
=======================================
  Hits         4766     4766           
  Misses        262      262           
  Partials        3        3           

@ajimae ajimae requested a review from markus-azer August 4, 2023 11:14
@@ -27,13 +27,16 @@
"contributors": [
"Williams Omayuku <williams.omayuku@commercetools.com>"
],
"main": "lib/index.js",
"main": "dist/discount-code-importer.cjs.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make it consistent with other packages?
I notice that most of the importer/exporter package have a consistent structure

https://github.com/commercetools/nodejs/blob/804c7ca8bf62d248e764ed999168f9f149f3bc4a/packages/category-exporter/package.json#L12C4-L12C25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I will look at it now

- rewrite the build process of all packages using babel to use rollup instead
- build and reconfigure all cli files
- fix missing module path in integration test for personal-data-erasure module
@ajimae ajimae force-pushed the fix/module-exports-in-discount-code-importer branch from 39eab8b to 70b1d22 Compare August 7, 2023 15:27
- include a new rollup config to bundle cli modules
- add new postbuild script to build bundles
@ajimae ajimae closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants