-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exports in discount-code-importer module #1879
Conversation
- use preconstruct and rollup bundler to bundle module - remove the direct babel module bunder
|
Codecov Report
@@ Coverage Diff @@
## master #1879 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 147 147
Lines 5031 5031
Branches 1371 1371
=======================================
Hits 4766 4766
Misses 262 262
Partials 3 3 |
@@ -27,13 +27,16 @@ | |||
"contributors": [ | |||
"Williams Omayuku <williams.omayuku@commercetools.com>" | |||
], | |||
"main": "lib/index.js", | |||
"main": "dist/discount-code-importer.cjs.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make it consistent with other packages?
I notice that most of the importer/exporter package have a consistent structure
"main": "lib/main.js", |
"main": "lib/main.js", |
"main": "lib/main.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will look at it now
- rewrite the build process of all packages using babel to use rollup instead - build and reconfigure all cli files
- fix missing module path in integration test for personal-data-erasure module
39eab8b
to
70b1d22
Compare
- include a new rollup config to bundle cli modules - add new postbuild script to build bundles
Summary
Fix issues with modules not exporting directly as default exports in
@commercetools/discount-code-importer
package.Completed tasks