Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize auth.js: Replace Buffer.from(x).toString('base64') with btoa #1651

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

studentIvan
Copy link
Contributor

@studentIvan studentIvan commented Jan 24, 2021

Summary

IE10+ browsers support btoa function. Do we really need 50kb Buffer polyfill in the browser?
With this pull request #1650 we can just get rid of the entire Buffer's polyfill

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation
  • Type label for the PR

IE10+ browsers support btoa function. Do we really need 50kb Buffer polyfill in the browser?
@studentIvan studentIvan changed the title Get rid of Buffer.from polyfill requirement Optimize auth.js: Get rid of Buffer.from polyfill requirement Jan 24, 2021
@studentIvan studentIvan changed the title Optimize auth.js: Get rid of Buffer.from polyfill requirement Optimize auth.js: Replace Buffer.from(x).toString('base64') with btoa Jan 24, 2021
@studentIvan
Copy link
Contributor Author

For ones who using it with Babel/Webpack and a browser, you can hack this using this way:

import SdkAuth, { TokenProvider } from '@commercetools/sdk-auth/dist/sdk-auth.es';

if (typeof Buffer === 'undefined' && typeof window !== 'undefined') {
  window.Buffer = {
    from: s => ({ toString: m => m === 'base64' ? btoa(s) : m }),
    byteLength: s => s.length,
  };
}

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2023

⚠️ No Changeset found

Latest commit: ae68159

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ajimae ajimae self-requested a review May 30, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants