Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-request-builder): resetting customerId and cartId params #1628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(api-request-builder): resetting customerId and cartId params #1628

wants to merge 2 commits into from

Conversation

jimmythomson
Copy link

Fixes: #1627

Resets the customerId and cartId params to null after the build method has generated a uri.

daern91
daern91 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@daern91 daern91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the contribution! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daern91 daern91 daern91 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customerId and cartId params not being reset between calls to build
2 participants
@jimmythomson @daern91