Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customerId and cartId params not being reset between calls to build #1627

Open
jimmythomson opened this issue Sep 28, 2020 · 0 comments · May be fixed by #1628
Open

customerId and cartId params not being reset between calls to build #1627

jimmythomson opened this issue Sep 28, 2020 · 0 comments · May be fixed by #1628

Comments

@jimmythomson
Copy link

Description

When using byCustomerId or byCartId in api-request-builder, the locally stored params are not cleared before the next call to build.

Expected Behavior

The setDefaultParams function should reset the customerId and cartId params.

Current Behavior

The customerId and cartId params are not cleared between calls to build.

Context

This bug was discovered when attempting to build multiple queries, one after the other.

Possible Solution

Will create a PR shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api-request-builder): resetting customerId and cartId params gradientedge/nodejs
1 participant
@jimmythomson