Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mc-scripts): local login dev for internal usage #2626

Merged
merged 1 commit into from Jun 3, 2022
Merged

fix(mc-scripts): local login dev for internal usage #2626

merged 1 commit into from Jun 3, 2022

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 27, 2022

Caused by #2568

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

🦋 Changeset detected

Latest commit: 545ed78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

emmenko
emmenko commented May 27, 2022
View reviewed changes
packages/mc-scripts/src/config/webpack-dev-server.config.js
Comment on lines -55 to +53
middlewares.push(createMcDevAuthenticationMiddleware(applicationConfig));
devServer.app.use(createMcDevAuthenticationMiddleware(applicationConfig));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. Apparently using the middlewares list didn't really work as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, I read the documentation to verify but it also does this. When debugging the production build on the middlewares, the only thing I noticed it that it wasn't called.

@emmenko emmenko requested review from tdeekens and a team May 27, 2022 14:40
@github-actions github-actions bot temporarily deployed to Preview May 27, 2022 14:46 Destroyed
@github-actions
Copy link
Contributor

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-g2thdzdyw-commercetools.vercel.app
https://appkit-sha-bfb09867672646ec1b76f600a0371725b3e64cc0.commercetools.vercel.app
https://appkit-pr-2626.commercetools.vercel.app

Built with commit 545ed78.
This pull request is being automatically deployed with vercel-action

CarlosCortizasCT
CarlosCortizasCT approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmenko emmenko merged commit eea4f5f into main Jun 3, 2022
@emmenko emmenko deleted the nm-fix-local-login-dev branch June 3, 2022 09:50
@ghost ghost mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emmenko @tdeekens @CarlosCortizasCT