Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mc-scripts): downgrade react-refresh to v0.11.0 #2534

Merged
merged 1 commit into from
Apr 4, 2022
Merged

fix(mc-scripts): downgrade react-refresh to v0.11.0 #2534

merged 1 commit into from
Apr 4, 2022

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Apr 4, 2022

Caused by #2528

Ref: facebook/react#24235

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: b5c28ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@commercetools-frontend/mc-scripts Patch
merchant-center-application-template-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 4, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/merchant-center-application-kit/BXeaSSGjdqcVUuwkFkwcNtJG16Wc
✅ Preview: https://merchant-center-application-kit-git-nm-fix-95e836-commercetools.vercel.app

emmenko
emmenko commented Apr 4, 2022
View reviewed changes
.github/workflows/main.yml
Comment on lines +68 to +74
- name: Testing Starter application development server
run: yarn start-server-and-test 'yarn template-starter:start' 3001 'exit 0'
env:
HOST_GCP_STAGING: ${{ secrets.HOST_GCP_STAGING }}
APP_ID: ${{ secrets.APP_ID_PLAYGROUND }}
MC_API_URL: ${{ secrets.MC_API_URL }}
CTP_INITIAL_PROJECT_KEY: ${{ secrets.CYPRESS_PROJECT_KEY }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now catch these kind of errors for using the development server.

Otherwise on CI we have only been testing the production builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 👍

@emmenko emmenko requested a review from a team April 4, 2022 12:56
Rhotimee
Rhotimee approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@Rhotimee Rhotimee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

CarlosCortizasCT
CarlosCortizasCT approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tdeekens
tdeekens approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good follow-up!

@emmenko emmenko merged commit 6b25e4e into main Apr 4, 2022
@emmenko emmenko deleted the nm-fix-react-refresh-version-0.11 branch April 4, 2022 13:44
@ghost ghost mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

@tdeekens tdeekens tdeekens approved these changes

@Rhotimee Rhotimee Rhotimee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emmenko @tdeekens @Rhotimee @CarlosCortizasCT