Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ProductDataLike serialization #346

Merged
merged 1 commit into from Jul 29, 2022
Merged

fix ProductDataLike serialization #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ools-sdk-java-api/src/main/java/com/commercetools/api/models/product/ProductDataLike.java
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@
import com.commercetools.api.models.common.LocalizedString;
import com.commercetools.api.models.common.MetaAttributes;
import com.commercetools.api.models.common.WithLocalizedSlug;
import com.fasterxml.jackson.annotation.JsonIgnore;

/**
* Interface to describe commonalities between differen product representations
Expand Down Expand Up @@ -60,6 +61,7 @@ public interface ProductDataLike extends WithLocalizedSlug, MetaAttributes {
* @see #getVariants()
* @return all variants
*/
@JsonIgnore
default List<ProductVariant> getAllVariants() {
return ProductsPackage.getAllVariants(this);
}
Expand Down
19 changes: 15 additions & 4 deletions commercetools/commercetools-sdk-java-api/src/test/java/com/commercetools/ProductTest.java
View file
Open in desktop
Expand Up @@ -6,11 +6,11 @@
import java.util.stream.Collectors;

import com.commercetools.api.models.common.LocalizedStringBuilder;
import com.commercetools.api.models.product.ProductDraft;
import com.commercetools.api.models.product.ProductDraftBuilder;
import com.commercetools.api.models.product.ProductVariantDraft;
import com.commercetools.api.models.product.ProductVariantDraftBuilder;
import com.commercetools.api.models.product.*;
import com.commercetools.api.models.product_type.ProductTypeResourceIdentifierBuilder;
import com.fasterxml.jackson.core.JsonProcessingException;

import io.vrap.rmf.base.client.utils.json.JsonUtils;

import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;
Expand All @@ -37,4 +37,15 @@ public void draft() {
Assertions.assertThat(draft.getVariants()).hasSize(1);
Assertions.assertThat(draft.getVariants().get(0).getSku()).isEqualTo("def");
}

@Test
public void serializeProduct() throws JsonProcessingException {
final ProductProjection productProjection = ProductProjection.builder()
.masterVariant(b -> b.sku("foo").id(1L))
.plusVariants(b -> b.sku("bar").id(2L))
.buildUnchecked();

Assertions.assertThat(JsonUtils.toJsonString(productProjection))
.isEqualTo("{\"masterVariant\":{\"id\":1,\"sku\":\"foo\"},\"variants\":[{\"id\":2,\"sku\":\"bar\"}]}");
}
}