-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document use of asb export-bitcoin-wallet #1280
Conversation
Add to the `asb` document @delta1's text on exporting the Bitcoin wallet descriptor and importing the descriptor into Sparrow Wallet. TODO: maybe it would make sense to add the images to Git, instead of linking to files on Github?
Looks like one integration test fails, but it's not my fault |
It's a timeout, happens from time to time |
These bulletpoints are formatted in a very weird way. Please use normal bulletpoints.
Fixed. The formatting was directly copied from @delta1's original text,
so I assumed it was formatted according the project style.
|
Thanks @icy-ux, I think this could be written better and not need the images, and I'd also like to figure out how to import it into the |
Yeah true, I see why you did that. Really no offense intended. Thank you alot for the PR, we really need to improve the documentation overall. |
@icy-ux please run dprint fmt and then I’m happy for this to go in, it can always be updated later. |
@icy-ux please run dprint fmt and then I’m happy for this to go in, it can always be updated later.
Done.
Unfortunately the backticks in my commit message were cut out along the
way, so it's not the best commit message in the world.
|
Thanks! No problem, please squash your commits into 1, make sure it’s GPG signed, force push and then we’ll get this merged. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
+1 to adding the images to version control, in the docs folder |
@delta1 done, should be ready to merge |
Add to the
asb
document @delta1's text on exporting the Bitcoin walletdescriptor and importing the descriptor into Sparrow Wallet. Addresses #878
TODO: maybe it would make sense to add the images to Git, instead of
linking to files on Github?