Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document use of asb export-bitcoin-wallet #1280

Merged
merged 7 commits into from
May 20, 2024

Conversation

icy-ux
Copy link
Contributor

@icy-ux icy-ux commented Jan 12, 2023

Add to the asb document @delta1's text on exporting the Bitcoin wallet
descriptor and importing the descriptor into Sparrow Wallet. Addresses #878

TODO: maybe it would make sense to add the images to Git, instead of
linking to files on Github?

Add to the `asb` document @delta1's text on exporting the Bitcoin wallet
descriptor and importing the descriptor into Sparrow Wallet.

TODO: maybe it would make sense to add the images to Git, instead of
linking to files on Github?
@icy-ux
Copy link
Contributor Author

icy-ux commented Jan 12, 2023

Looks like one integration test fails, but it's not my fault

docs/asb/README.md Outdated Show resolved Hide resolved
@binarybaron
Copy link
Collaborator

Looks like one integration test fails, but it's not my fault

It's a timeout, happens from time to time

@comit-network comit-network deleted a comment from binarybaron Jan 13, 2023
@icy-ux
Copy link
Contributor Author

icy-ux commented Jan 13, 2023 via email

@delta1
Copy link
Collaborator

delta1 commented Jan 13, 2023

Thanks @icy-ux, I think this could be written better and not need the images, and I'd also like to figure out how to import it into the bdk cli correctly.

@binarybaron
Copy link
Collaborator

These bulletpoints are formatted in a very weird way. Please use normal bulletpoints.

Fixed. The formatting was directly copied from @delta1's original text,
so I assumed it was formatted according the project style.

Yeah true, I see why you did that. Really no offense intended. Thank you alot for the PR, we really need to improve the documentation overall.

@delta1
Copy link
Collaborator

delta1 commented Jan 13, 2023

@icy-ux please run dprint fmt and then I’m happy for this to go in, it can always be updated later.

@icy-ux
Copy link
Contributor Author

icy-ux commented Jan 14, 2023 via email

@delta1
Copy link
Collaborator

delta1 commented Jan 14, 2023

Thanks! No problem, please squash your commits into 1, make sure it’s GPG signed, force push and then we’ll get this merged.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@ikmckenz
Copy link
Contributor

+1 to adding the images to version control, in the docs folder

@delta1
Copy link
Collaborator

delta1 commented Apr 30, 2024

@ikmckenz @icy-ux please add a commit including the images and updating the paths in the md file

@icy-ux
Copy link
Contributor Author

icy-ux commented May 18, 2024

@delta1 done, should be ready to merge

@delta1 delta1 merged commit 8d8c938 into comit-network:master May 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants