This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
Remove chai-bignumber #2558
Merged
Remove chai-bignumber #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 30, 2020 15:36
Because we do not use them a lot and they actually re-define @types/jest without bigint support.
There are no jest plugin to support BigNumber.js in `expect`, however, it natively supports `bigint`. Hence, remove usage of `BigNumber` and `chai.expect` in this class, the intent is to continue replacing `BigNumber` with `bigint` in other classes.
|
Are you sure the changelog does not need updating? |
thomaseizinger
previously approved these changes
Apr 30, 2020
tcharding
approved these changes
Apr 30, 2020
bonomat
reviewed
Apr 30, 2020
bonomat
approved these changes
Apr 30, 2020
Merged
added 2 commits
May 1, 2020 15:03
Jest actually support bigint, the types are not up to date.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chai-bignumberdependency.BigNumberwithbigintNeeds DefinitelyTyped/DefinitelyTyped#44368 to be merged and released.Edit: using
@ts-ignorefor now.Helps with #2139.