Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added poetry integration. #368

Merged
merged 10 commits into from Oct 9, 2021
Merged

Added poetry integration. #368

merged 10 commits into from Oct 9, 2021

Conversation

s3rius
Copy link
Contributor

@s3rius s3rius commented Oct 8, 2021

Description:

  • Fixed github actions;
  • Removed requirements.txt;
  • Fixed CONTRIBUTING.md;
  • Fixed black and flake8.

Closes #367.

Signed-off-by: Pavel win10@list.ru

Description:
* Fixed github actions;
* Removed requirements.txt;
* Fixed CONTRIBUTING.md;
* Fixed black and flake8.

Signed-off-by: Pavel <win10@list.ru>
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #368 (f28e16d) into master (80c6ff3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #368   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines        14811     14816    +5     
=========================================
+ Hits         14811     14816    +5     
Impacted Files Coverage Δ
ormar/exceptions.py 100.00% <ø> (ø)
ormar/fields/through_field.py 100.00% <ø> (ø)
ormar/models/mixins/prefetch_mixin.py 100.00% <ø> (ø)
ormar/models/mixins/pydantic_mixin.py 100.00% <ø> (ø)
ormar/queryset/clause.py 100.00% <ø> (ø)
ormar/relations/alias_manager.py 100.00% <ø> (ø)
ormar/relations/utils.py 100.00% <ø> (ø)
tests/test_encryption/test_encrypted_columns.py 100.00% <ø> (ø)
tests/test_fastapi/test_more_reallife_fastapi.py 100.00% <ø> (ø)
...and_pydantic_generation/test_inheritance_mixins.py 100.00% <ø> (ø)
... and 40 more

Signed-off-by: Pavel <win10@list.ru>
Signed-off-by: Pavel <win10@list.ru>
@s3rius
Copy link
Contributor Author

s3rius commented Oct 9, 2021

Why does python 3.6 has so many mypy issues?

I've fixed all issues in python3.7 but i couldn't fix all issues in py3.6.

@collerek
Copy link
Owner

collerek commented Oct 9, 2021

Why does python 3.6 has so many mypy issues?

I've fixed all issues in python3.7 but i couldn't fix all issues in py3.6.

I have no idea - something changed in between, all was passing till now.
See that mypy-extensions are installed for 3.6 🤷

Had to add types-dataclasses for p3.6

@collerek collerek merged commit 8dc1ebc into collerek:master Oct 9, 2021
@collerek
Copy link
Owner

collerek commented Oct 9, 2021

Thanks a lot @s3rius ! 😁
Merged so will close the other one :)

@s3rius
Copy link
Contributor Author

s3rius commented Oct 9, 2021

Hoooray! Thanks you. I'll add ormar support in fastapi-template as fast as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python_version marker constraint in setup.py
3 participants