Bug Fix: Compatibility for sqlalchemy>=1.4.0 #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the pr! :) Unfortunately if databases won't merge it's pr as described in #142 it won't be possible as the databases will crush. |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 167 167
Lines 14237 14237
=========================================
Hits 14237 14237
|
|
encode/databases@89efe60 has been merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-1.4.18 and sqlalchemy/sqlalchemy#6153
This may not be everything needed for compatibility, but it puts ormar in the right direction