Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlalchemy to support >=1.4 #142

Closed
collerek opened this issue Apr 6, 2021 · 4 comments
Closed

Update sqlalchemy to support >=1.4 #142

collerek opened this issue Apr 6, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@collerek
Copy link
Owner

collerek commented Apr 6, 2021

After databases merge their solution and stop blocking the update: encode/databases#299

@collerek collerek added the enhancement New feature or request label Apr 6, 2021
@johnthagen
Copy link
Contributor

johnthagen commented Apr 21, 2021

Would the fact that sqlalchemy 1.4 has native async support bring any improvements?

@collerek
Copy link
Owner Author

Immediately - no - since all queries are run through encode/databases.

This issue is rather to not block bumping version of sqlalchemy if you use it in other then ormar places, and I need to adjust ormar as version >= 1.4 has some breaking changes even without async support.

But looking at how encode/databases is half-abandoned in the long run I will probably switch fully to sqlalchemy, but that is a bigger refactor and since async support is still in alpha version in sqlalchemy (I'm also not very fond of the async API but I need to dig deeper) I'm waiting to see how the situation will develop.

@ghost
Copy link

ghost commented Aug 26, 2021

This has been merged into encode/databases for 0.5.0.

@collerek
Copy link
Owner Author

Added in 0.10.17 (#325)

@collerek collerek mentioned this issue Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants