Migrate to JSDOM #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoikin
commented
Sep 16, 2022
Comment on lines
+105
to
+107
| import Elmish.Test.Discover (childAt, children, find, findAll, findFirst, findNth) | ||
| import Elmish.Test.Events (change, click, clickOn, fireEvent) | ||
| import Elmish.Test.Query (attr, exists, find, findAll, findFirst, findNth, html, prop, tagName, text) | ||
| import Elmish.Test.Query (attr, count, exists, html, prop, tagName, text) |
There was a problem hiding this comment.
I broke up the Query module into Query (reading properties of elements) and Discover (manipulating/traversing the DOM tree). Initially it was necessary for my implementation of innerText to avoid cyclic imports. I changed the implementation since then, but decided to leave the separation.
fsoikin
commented
Sep 16, 2022
| @@ -8,8 +8,6 @@ newtype DomProp (a :: Type) = DomProp String | |||
|
|
|||
| value = DomProp "value" :: DomProp String | |||
|
|
|||
| href = DomProp "href" :: DomProp String | |||
There was a problem hiding this comment.
Turns out this is a not a property. Only accessible via getAttribute.
fsoikin
commented
Sep 16, 2022
Comment on lines
+33
to
+34
| count :: ∀ m. Testable m => String -> m Int | ||
| count selector = length <$> findAll selector |
There was a problem hiding this comment.
Turns out we're utilizing this in our codebase a lot, I had to convert all those places to findAll "..." >>= Array.length, which is less readable. So I decided to add this utility here.
mcordova47
approved these changes
Sep 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, looks like we have to move back to JSDOM, at least for now.
First there was the
oninputkerfuffle, which can be monkey-patched, and now I also discovered that<button>properties aren't being handler correctly, which is much harder to monkey-patch.It appears that there has been a two-month lull in
happy-dommaintenance (last commit merged on July 24th, and there are 17 open PRs as of now), which raises a concern that the above issues might not get fixed soon.So, for now, we're moving back to JSDOM, and patching its deficiencies instead. So far I know of three problems:
innerText- this looks like it could be reasonably replaced withtextContent(see the list of differences on MDN), which is what I've done in this PR.window.scrollTo, which crashes when called. This can be masked in the consuming codebase withwindow.scrollTo = () => {}. I don't want to mask errors in the library.window.location.href. Will have to be similarly patched.On the bright side, it doesn't look like JSDOM has to be registered before React is included after all. Just-in-time registration seems to work fine so far.