Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement hash and __eq__ for vDDDTypes #492

Merged
merged 6 commits into from Nov 17, 2022
Merged

implement hash and __eq__ for vDDDTypes #492

merged 6 commits into from Nov 17, 2022

Commits on Nov 10, 2022

  1. add tests to test hash and __eq__

    @niccokunzmann
    niccokunzmann committed Nov 10, 2022
    Copy the full SHA
    b1a108d View commit details
    Browse the repository at this point in the history

  2. implement hash based on the dt value

    @niccokunzmann
    niccokunzmann committed Nov 10, 2022
    Copy the full SHA
    185065e View commit details
    Browse the repository at this point in the history

  3. make tests fail if the parameters equal 

    This __eq__ implementation is faulty. The .dt property should be compared, too
    @niccokunzmann
    niccokunzmann committed Nov 10, 2022
    Copy the full SHA
    53567ef View commit details
    Browse the repository at this point in the history

  4. add vDDDTypes.dt to __eq__

    @niccokunzmann
    niccokunzmann committed Nov 10, 2022
    Copy the full SHA
    6808972 View commit details
    Browse the repository at this point in the history

  5. add changelog entry

    @niccokunzmann
    niccokunzmann committed Nov 10, 2022
    Copy the full SHA
    b486ec9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. add a check that a timezone difference matters to equality 

    see #492 (comment)
    @niccokunzmann
    niccokunzmann committed Nov 16, 2022
    Copy the full SHA
    ae9ac71 View commit details
    Browse the repository at this point in the history