New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prop.py #482
Update prop.py #482
Conversation
Pull Request Test Coverage Report for Build 3359412227
💛 - Coveralls |
Please add a hacktoberfest label to this PR if possible. |
@pronoym99 Could you add yourself to the changelog and contributors list as per CONTRIBUTING? |
Yes sure. |
@jacadzaca Done the required changes. Please have a look. |
@pronoym99 I did, you've pushed the changes to #481 |
@jacadzaca bifurcated CHANGES pertaining to each of #481, #482 and #483. |
@pronoym99 Great, could you now format the changelog as I've asked and put it under the 5.0.2 version, please? Could you also squash your commits, two commits per PR seem resonable -- we don't want to pollute the log with changelog update. |
@jacadzaca I have squashed the commits for this PR and updated the changelog by adding the changes in 5.0.2 as requested by you. |
@pronoym99 I think your squash didn't work since there are still 7 commits? |
@jacadzaca Yes. I was doing it using the GitKraken app. I need to do so in the cmd line. Maybe it will work there. |
I'd also phrase the changelog entry differently, e.g |
Thanks for the PR! I left a comment. Also, this CHANGES file is quite big.. |
Thanks for your changes! |
* Update cal.py * Update credits.rst pertaining to #482 * Update CHANGES.rst pertaining to #482 * Update CHANGES.rst pertaining to #481 * Update CHANGES.rst pertaining to #483 * Update CHANGES.rst * Update credits.rst and changes.rst pertaining to #481 * Update CHANGES.rst * Update CHANGES.rst * Update CHANGES.rst * Update CHANGES.rst * Update cal.py * Update cal.py * Update CHANGES.rst * Update cal.py * Update cal.py * Update cal.py * Update tools.py * Update parser.py * Update CHANGES.rst
format
strings to python3.6+ compliantf-strings
wherever possible.if - else
statements with equivalent boolean expressions.