Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prop.py #482

Merged
merged 14 commits into from Oct 31, 2022
Merged

Update prop.py #482

merged 14 commits into from Oct 31, 2022

Conversation

pronoym99
Copy link
Contributor

  1. Convert format strings to python3.6+ compliant f-strings wherever possible.
  2. Optimise return statements of functions having rudimentary if - else statements with equivalent boolean expressions.

@coveralls
Copy link

coveralls commented Oct 30, 2022

Pull Request Test Coverage Report for Build 3359412227

  • 25 of 38 (65.79%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 93.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/prop.py 25 38 65.79%
Files with Coverage Reduction New Missed Lines %
src/icalendar/prop.py 2 87.0%
Totals Coverage Status
Change from base Build 3354567871: 0.3%
Covered Lines: 1161
Relevant Lines: 1244

💛 - Coveralls

@pronoym99
Copy link
Contributor Author

Please add a hacktoberfest label to this PR if possible.

@jacadzaca jacadzaca added the hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ label Oct 30, 2022
@jacadzaca
Copy link
Collaborator

jacadzaca commented Oct 30, 2022

@pronoym99 Could you add yourself to the changelog and contributors list as per CONTRIBUTING?

@pronoym99
Copy link
Contributor Author

Yes sure.

@pronoym99
Copy link
Contributor Author

pronoym99 commented Oct 30, 2022

@jacadzaca Done the required changes. Please have a look.

@jacadzaca
Copy link
Collaborator

@pronoym99 I did, you've pushed the changes to #481

@pronoym99
Copy link
Contributor Author

@jacadzaca bifurcated CHANGES pertaining to each of #481, #482 and #483.

@jacadzaca
Copy link
Collaborator

@pronoym99 Great, could you now format the changelog as I've asked and put it under the 5.0.2 version, please? Could you also squash your commits, two commits per PR seem resonable -- we don't want to pollute the log with changelog update.

@pronoym99
Copy link
Contributor Author

@jacadzaca I have squashed the commits for this PR and updated the changelog by adding the changes in 5.0.2 as requested by you.

@jacadzaca
Copy link
Collaborator

@pronoym99 I think your squash didn't work since there are still 7 commits?

@pronoym99
Copy link
Contributor Author

@jacadzaca Yes. I was doing it using the GitKraken app. I need to do so in the cmd line. Maybe it will work there.

@jacadzaca
Copy link
Collaborator

I'd also phrase the changelog entry differently, e.g converted all format strings into f-strings in prop.py or just refactored prop.py. The one now is a bit of a mouthful. That's up to you tho :)

@jacadzaca jacadzaca self-requested a review October 30, 2022 21:37
author lukex9442 <lukex9442@gmail.com> 1667160311 +0530
committer Pronoy <lukex9442@gmail.com> 1667197160 +0530

Update CHANGES.rst pertaining to #482
@niccokunzmann
Copy link
Member

Thanks for the PR! I left a comment. Also, this CHANGES file is quite big..

@niccokunzmann niccokunzmann merged commit cb2ccaa into collective:master Oct 31, 2022
@niccokunzmann
Copy link
Member

Thanks for your changes!

@pronoym99 pronoym99 deleted the patch-3 branch October 31, 2022 15:32
angatha pushed a commit that referenced this pull request Oct 31, 2022
* Update cal.py

* Update credits.rst pertaining to #482

* Update CHANGES.rst pertaining to #482

* Update CHANGES.rst pertaining to #481

* Update CHANGES.rst pertaining to #483

* Update CHANGES.rst

* Update credits.rst and changes.rst pertaining to #481

* Update CHANGES.rst

* Update CHANGES.rst

* Update CHANGES.rst

* Update CHANGES.rst

* Update cal.py

* Update cal.py

* Update CHANGES.rst

* Update cal.py

* Update cal.py

* Update cal.py

* Update tools.py

* Update parser.py

* Update CHANGES.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants