New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download compressed gz image from remote source #41
Conversation
b4bdc49
to
2c88656
Compare
2c88656
to
b1e7563
Compare
Takes some of the intended changes of #34 applying review comments. |
bb61d3b
to
eec84da
Compare
c2a8337
to
1d8a0f8
Compare
05585e2
to
60800ad
Compare
The idea is to make the code clearer and more readable, and also leave the |
5990e31
to
6726fa1
Compare
The idea is to make the code clearer and more readable, and also leave the |
@Razaloc Can you resolve the merge conflicts ? |
c80967c
to
8691dc5
Compare
b8fe715
to
04885a0
Compare
04885a0
to
43ff1e8
Compare
77d760c
to
6f11483
Compare
Prepare bmap copy from remote source. Create an asynchronous alternative pipeline for asynchronous copy data downloaded from remote source. We want the data to be streamed into the copying function instead of be fully downloaded before the copy start, shortening the duration of the overall process. Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Change the use of clap from 'derive' to 'builder' mode. The goal is to allow Copy.image to be an enum holding a PathBuf or an Url, allowing Url inputs for the copy function. This way, we only parse the input value once. Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
The current copy function and the future copy_remote_input function will share a lot of code. We are trying to reduce that duplication, extracting parts and creating setup_progress_bar and setup_output. Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
Accept Url arguments for remote image download and copy. Implements async support for use of reqwest. Bmap file is searched as in local option in the current file with same name and the extension ".bmap" Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
When downloading the image from a remote source, the bmap will also be searched remotely and downloaded. The bmap url will be the same as image url, but replacing the final extension with ".bmap". Signed-off-by: Rafael Garcia Ruiz <rafael.garcia@collabora.com>
6f11483
to
5a6e346
Compare
bors r+ |
Build succeeded: |
Accept url arguments for remote image download and copy.
Implements async support for use of reqwest. Bmap file is searched as in
local option in the current file with same name and the extension ".bmap"
Closes: #9
Closes: #46
Closes: #8
Signed-off-by: Rafael Garcia Ruiz rafael.garcia@collabora.com