-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test showing that Go To Definition is broken on object properties
- Loading branch information
Showing
6 changed files
with
389 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import * as z from "../index.ts"; | ||
|
||
export const Test = z.object({ | ||
f1: z.number(), | ||
}); | ||
|
||
export type Test = z.infer<typeof Test>; | ||
|
||
export const instanceOfTest: Test = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestMerge = z | ||
.object({ | ||
f5: z.literal("literal").optional(), | ||
}) | ||
.merge(Test); | ||
|
||
export type TestMerge = z.infer<typeof TestMerge>; | ||
|
||
export const instanceOfTestMerge: TestMerge = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestUnion = z.union([ | ||
z.object({ | ||
f2: z.literal("literal").optional(), | ||
}), | ||
Test, | ||
]); | ||
|
||
export type TestUnion = z.infer<typeof TestUnion>; | ||
|
||
export const instanceOfTestUnion: TestUnion = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestPartial = Test.partial(); | ||
|
||
export type TestPartial = z.infer<typeof TestPartial>; | ||
|
||
export const instanceOfTestPartial: TestPartial = { | ||
f1: 1, | ||
}; | ||
|
||
export const filePath = __filename; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
// @ts-ignore TS6133 | ||
import { expect } from "https://deno.land/x/expect@v0.2.6/mod.ts"; | ||
const test = Deno.test; | ||
import { filePath } from "./languageServerFeatures.source.ts"; | ||
import { Project, Node, SyntaxKind } from "ts-morph"; | ||
import path from "path"; | ||
|
||
// The following tool is helpful for understanding the TypeScript AST associated with these tests: | ||
// https://ts-ast-viewer.com/ (just copy the contents of languageServerFeatures.source into the viewer) | ||
|
||
describe("Executing Go To Definition (and therefore Find Usages and Rename Refactoring) using an IDE works on inferred object properties", () => { | ||
// Compile file developmentEnvironment.source | ||
const project = new Project({ | ||
tsConfigFilePath: path.join(__dirname, "..", "..", "tsconfig.json"), | ||
skipAddingFilesFromTsConfig: true, | ||
}); | ||
const sourceFile = project.addSourceFileAtPath(filePath); | ||
|
||
test("works for objects", () => { | ||
// Find usage of Test.f1 property | ||
const instanceVariable = | ||
sourceFile.getVariableDeclarationOrThrow("instanceOfTest"); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of Test.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for merged objects", () => { | ||
// Find usage of TestMerge.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestMerge" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestMerge.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for unioned objects", () => { | ||
// Find usage of TestUnion.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestUnion" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestUnion.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for partial objects", () => { | ||
// Find usage of TestPartial.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestPartial" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestPartial.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
}); | ||
|
||
const getPropertyBeingAssigned = (node: Node, name: string) => { | ||
const propertyAssignment = node.forEachDescendant((descendent) => | ||
Node.isPropertyAssignment(descendent) && descendent.getName() == name | ||
? descendent | ||
: undefined | ||
); | ||
|
||
if (propertyAssignment == null) | ||
fail(`Could not find property assignment with name ${name}`); | ||
|
||
const propertyLiteral = propertyAssignment.getFirstDescendantByKind( | ||
SyntaxKind.Identifier | ||
); | ||
|
||
if (propertyLiteral == null) | ||
fail(`Could not find property literal with name ${name}`); | ||
|
||
return propertyLiteral; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import * as z from "../index"; | ||
|
||
export const Test = z.object({ | ||
f1: z.number(), | ||
}); | ||
|
||
export type Test = z.infer<typeof Test>; | ||
|
||
export const instanceOfTest: Test = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestMerge = z | ||
.object({ | ||
f5: z.literal("literal").optional(), | ||
}) | ||
.merge(Test); | ||
|
||
export type TestMerge = z.infer<typeof TestMerge>; | ||
|
||
export const instanceOfTestMerge: TestMerge = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestUnion = z.union([ | ||
z.object({ | ||
f2: z.literal("literal").optional(), | ||
}), | ||
Test, | ||
]); | ||
|
||
export type TestUnion = z.infer<typeof TestUnion>; | ||
|
||
export const instanceOfTestUnion: TestUnion = { | ||
f1: 1, | ||
}; | ||
|
||
export const TestPartial = Test.partial(); | ||
|
||
export type TestPartial = z.infer<typeof TestPartial>; | ||
|
||
export const instanceOfTestPartial: TestPartial = { | ||
f1: 1, | ||
}; | ||
|
||
export const filePath = __filename; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
// @ts-ignore TS6133 | ||
import { expect, fit } from "@jest/globals"; | ||
import { filePath } from "./languageServerFeatures.source"; | ||
import { Project, Node, SyntaxKind } from "ts-morph"; | ||
import path from "path"; | ||
|
||
// The following tool is helpful for understanding the TypeScript AST associated with these tests: | ||
// https://ts-ast-viewer.com/ (just copy the contents of languageServerFeatures.source into the viewer) | ||
|
||
describe("Executing Go To Definition (and therefore Find Usages and Rename Refactoring) using an IDE works on inferred object properties", () => { | ||
// Compile file developmentEnvironment.source | ||
const project = new Project({ | ||
tsConfigFilePath: path.join(__dirname, "..", "..", "tsconfig.json"), | ||
skipAddingFilesFromTsConfig: true, | ||
}); | ||
const sourceFile = project.addSourceFileAtPath(filePath); | ||
|
||
test("works for objects", () => { | ||
// Find usage of Test.f1 property | ||
const instanceVariable = | ||
sourceFile.getVariableDeclarationOrThrow("instanceOfTest"); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of Test.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for merged objects", () => { | ||
// Find usage of TestMerge.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestMerge" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestMerge.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for unioned objects", () => { | ||
// Find usage of TestUnion.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestUnion" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestUnion.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
|
||
test("works for partial objects", () => { | ||
// Find usage of TestPartial.f1 property | ||
const instanceVariable = sourceFile.getVariableDeclarationOrThrow( | ||
"instanceOfTestPartial" | ||
); | ||
const propertyBeingAssigned = getPropertyBeingAssigned( | ||
instanceVariable, | ||
"f1" | ||
); | ||
|
||
// Find definition of TestPartial.f1 property | ||
const definitionOfProperty = propertyBeingAssigned?.getDefinitionNodes()[0]; | ||
const parentOfProperty = definitionOfProperty?.getFirstAncestorByKind( | ||
SyntaxKind.VariableDeclaration | ||
); | ||
|
||
// Assert that find definition returned the Zod definition of Test | ||
expect(definitionOfProperty?.getText()).toEqual("f1: z.number()"); | ||
expect(parentOfProperty?.getName()).toEqual("Test"); | ||
}); | ||
}); | ||
|
||
const getPropertyBeingAssigned = (node: Node, name: string) => { | ||
const propertyAssignment = node.forEachDescendant((descendent) => | ||
Node.isPropertyAssignment(descendent) && descendent.getName() == name | ||
? descendent | ||
: undefined | ||
); | ||
|
||
if (propertyAssignment == null) | ||
fail(`Could not find property assignment with name ${name}`); | ||
|
||
const propertyLiteral = propertyAssignment.getFirstDescendantByKind( | ||
SyntaxKind.Identifier | ||
); | ||
|
||
if (propertyLiteral == null) | ||
fail(`Could not find property literal with name ${name}`); | ||
|
||
return propertyLiteral; | ||
}; |
Oops, something went wrong.