Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom default fuction with owned pattern #315

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Support for custom default fuction with owned pattern #315

wants to merge 12 commits into from

Commits on Mar 23, 2024

  1. Base impl for custom defaults in owned pattern 

    There are still a lot of tests failing, but my usecase works.
Now I just have to fix all the corner cases. Also tests for the new
feature are still missing.
    @Wasabi375
    Wasabi375 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ee522ae View commit details
    Browse the repository at this point in the history

  2. Fix all tests/examples in derive_builder package 

    this still leaves tests in all other packages including tests for
internals in derive_builder_core
    @Wasabi375
    Wasabi375 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    7161d93 View commit details
    Browse the repository at this point in the history

  3. Fix fields order in initializers to match upstream

    @Wasabi375
    Wasabi375 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    97a6cab View commit details
    Browse the repository at this point in the history

  4. Removed unused fields from initializer

    @Wasabi375
    Wasabi375 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    09bcb83 View commit details
    Browse the repository at this point in the history

  5. Fix tests in initializer.rs

    @Wasabi375
    Wasabi375 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    1c4b118 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Fix build_method tests 

    turns out having a todo in the test data generation is not good if you
want the tests to pass :)
    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    bfbfe5b View commit details
    Browse the repository at this point in the history

  2. Tests for field_default_values

    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    7729bb9 View commit details
    Browse the repository at this point in the history

  3. Fix compile-fail crate_root test

    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    ad622f8 View commit details
    Browse the repository at this point in the history

  4. remove conversion from field_default_value + docs 

    conversion is only used to disable the default value if the enum is not
OptionOrDefault. It's cleaner to just use an enabled flag for that.
    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    0b75a7f View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    c342aba View commit details
    Browse the repository at this point in the history

  6. fix clippy warning

    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    33b1a45 View commit details
    Browse the repository at this point in the history

  7. Move default calculation for disabled fields into field_default_value

    @Wasabi375
    Wasabi375 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    c2510cf View commit details
    Browse the repository at this point in the history