Adds a check for strip_option when using try_setter

[chanced]

Fixes #284.

[chanced]

One of the tests is failing and I don't know how to solve it. This is my first time working on a proc macro.

The test is:

   #[test]
    fn strip_option_try_setter() {
        let ty = parse_quote!(Option<Foo>);
        let mut setter = default_setter!();
        setter.strip_option = true;
        setter.try_setter = true;
        setter.generic_into = true;
        setter.field_type = BuilderFieldType::Optional(&ty);
        assert_eq!(
            quote!(#setter).to_string(),
            quote!(
                #[allow(unused_mut)]
                pub fn foo<VALUE: ::db::export::core::convert::Into<Foo>>(
                    &mut self,
                    value: VALUE,
                ) -> &mut Self {
                    let mut new = self;
                    new.foo = ::db::export::core::option::Option::Some(
                        ::db::export::core::option::Option::Some(value.into()),
                    );
                    new
                }
                pub fn try_foo<VALUE: ::db::export::core::convert::TryInto<Foo>>(
                    &mut self,
                    value: VALUE,
                ) -> ::db::export::core::result::Result<&mut Self, VALUE::Error> {
                    let converted: Foo = value.try_into()?;
                    let mut new = self;
                    new.foo = ::db::export::core::option::Option::Some(
                        ::db::export::core::option::Option::Some(converted),
                    );
                    Ok(new)
                }
            )
            .to_string()
        );
    }

The issue is formatting. The assertion fails due to commas:

Diff < left / right > :
<"# [allow (unused_mut)] pub fn foo < VALUE : :: db :: export :: core :: convert :: Into < Foo >> (& mut self , value : VALUE) -> & mut Self { let mut new = self ; new . foo = :: db :: export :: core :: option :: Option :: Some (:: db :: export :: core :: option :: Option :: Some (value . into ())) ; new } pub fn try_foo < VALUE : :: db :: export :: core :: convert :: TryInto < Foo >> (& mut self , value : VALUE) -> :: db :: export :: core :: result :: Result < & mut Self , VALUE :: Error > { let converted : Foo = value . try_into () ? ; let mut new = self ; new . foo = :: db :: export :: core :: option :: Option :: Some (:: db :: export :: core :: option :: Option :: Some (converted)) ; Ok (new) }"
>"# [allow (unused_mut)] pub fn foo < VALUE : :: db :: export :: core :: convert :: Into < Foo >> (& mut self , value : VALUE ,) -> & mut Self { let mut new = self ; new . foo = :: db :: export :: core :: option :: Option :: Some (:: db :: export :: core :: option :: Option :: Some (value . into ()) ,) ; new } pub fn try_foo < VALUE : :: db :: export :: core :: convert :: TryInto < Foo >> (& mut self , value : VALUE ,) -> :: db :: export :: core :: result :: Result < & mut Self , VALUE :: Error > { let converted : Foo = value . try_into () ? ; let mut new = self ; new . foo = :: db :: export :: core :: option :: Option :: Some (:: db :: export :: core :: option :: Option :: Some (converted) ,) ; Ok (new) }"

[TedDriggs]

The issue appears to be the commas after the last parameters in the function signatures. Did rustfmt automatically add those?

If so, your best bet is probably to use #[rustfmt::skip] either on the whole test or on the assert_eq, and to add a comment saying why it needs to be disabled.

[chanced]

Ah, wasn't aware there was a cfg opt-out for formatting. Nice!

[TedDriggs]

Directionally looks good; some formatting and git hygiene requests and I think we'll be ready to merge.

[TedDriggs]

I got pulled into a bunch of other changes in other projects due to the release of syn 2, but I'm coming back to this now.

[TedDriggs]

Looks like the syn version bump has impacted us too - I'll put together an update tomorrow that increases the MSRV to reflect that.

[TedDriggs]

@chanced can you rebase this?

[chanced]

@TedDriggs sorry, missed this earlier. Done.