Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the codegen #245 to provide the ability to sensibly nest structs with builders. With this, our code in Arti can do this:
with the result that:
TorClientConfigBuilder
contains aNetworkConfigBuilder
.tor_client_config_builder.tor_network().fallback_caches(...)
.build()
calls for the sub-structures.tor_client_config_builder.build()
does it.impl TorClientConfigBuilder { pub fn tor_network(&mut self) -> &mut NetworkConfigBuilder { ... } }
can now be autogenerated rather than our current handwritten methodssub_builder
changes defaults for the contained field type and how to construct the target field, but you can still override them with the features from #245I guess you will have some opinions about the shape of the field attribute syntax...
Thanks again for your attention!