Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightlytests feature flag. Run all tests on all versions of Rust. #172

Merged
merged 5 commits into from Aug 11, 2020

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k commented Aug 2, 2020

This PR also bumps minimal version from 1.37.0 to 1.40.0. Skeptic and compiler tests require at least 1.38.0 and #[non_exhaustive] feature in PR #169 needs at least 1.40.0.

This also closes #140

@andy128k andy128k changed the title Remove nightlytests. Run all tests on all versions of Rust. Remove nightlytests feature flag. Run all tests on all versions of Rust. Aug 2, 2020
@andy128k
Copy link
Contributor Author

@TedDriggs bump :)

Copy link
Collaborator

@TedDriggs TedDriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor requested adjustments. Thanks for doing this.

derive_builder/CHANGELOG.md Show resolved Hide resolved
@andy128k
Copy link
Contributor Author

@TedDriggs Version is updated

@TedDriggs TedDriggs merged commit eb068f9 into colin-kiegel:master Aug 11, 2020
@andy128k andy128k deleted the remove-nightlytests branch August 11, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging feature is broken for env_logger v0.5.0+
2 participants