Add AmentInstalledPackageFinder for override warning #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
|
CI failed because of python/importlib_metadata#298 - which also means the flake8 linter didn't get a chance to run. I can double check it locally. |
jacobperron
approved these changes
Nov 24, 2021
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
jacobperron
approved these changes
Nov 29, 2021
|
Note when this is merged and released, it should include a version dependency on the released version of colcon-core with colcon/colcon-core#449 colcon/colcon-core#449 (comment) |
|
Merged with |
|
CI LGTM, and approved, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ros2/ros2#1150
Requires colcon/colcon-core#449
This adds a
FindInstalledPackagesExtensionPointextension that uses theament_indexto determine what packages are installed. It allows warning if any packages in/opt/ros/<rosdistro>are being overridden in a colcon workspace.