Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Compatibility with EmPy 4 #627

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Compatibility with EmPy 4 #627

wants to merge 1 commit into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 11, 2024

I believe this is the minimum set of changes necessary to use EmPy 4.

This needs to be updated to be compatible with EmPy 3 as well before being merged - there is no way we can cold-cut to v4.

@cottsay cottsay self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.30%. Comparing base (c7d8194) to head (fe92c5f).

Files Patch % Lines
colcon_core/shell/template/__init__.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   83.37%   83.30%   -0.08%     
==========================================
  Files          66       66              
  Lines        3789     3791       +2     
  Branches      737      737              
==========================================
- Hits         3159     3158       -1     
- Misses        556      557       +1     
- Partials       74       76       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant