Disable sitecustomize paths if in virtual env #623
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a sitecustomize python module is loaded during
ament_python
package installs.This impedes the use of a virtual environment during the install process, as is the case while using ament_virtualenv.
Due to sitecustomize module path configuration, mimicking the venv one, even if a script is executed using the venv python binary,
pyvenv.cfg
is not found and the path configuration will not be correct.With this fix, the sitecustomize path configuration will appy only while not using a virtual environment.
In particular in the case of
ament_virtualenv
, the pip dependencies will be installed in the venv lib, while the modules of the package being built will still end up in the package install lib.NB:
ament_virtualenv
is currently being ported to humble, I did not test it in the original targeted distribution (electron).